Move NodeListsNodeData class out of NodeRareData.h

Move NodeListsNodeData class out of NodeRareData.h

Move NodeListsNodeData class out of NodeRareData.h and into its own file as
it contains quite a bit of code. It may also help in cases where we need
NodeListsNodeData API but cannot include NodeRareData.h (because of circular
dependency).

R=esprehn@chromium.org, adamk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178090

[adamk, 2014-07-14 17:29:26]

lgtm (with a nit about the diff that's probably unimportant; this looks like
straight move of code)

https://codereview.chromium.org/390043003/diff/1/Source/core/dom/NodeListsNod...
File Source/core/dom/NodeListsNodeData.cpp (left):

https://codereview.chromium.org/390043003/diff/1/Source/core/dom/NodeListsNod...
Source/core/dom/NodeListsNodeData.cpp:32: #include
"core/timing/PerformanceEntry.h"
Unfortunate that git thinks this is a copy...maybe putting the shorter copyright
heading on this would fix that?

[Inactive, 2014-07-14 17:35:13]

https://codereview.chromium.org/390043003/diff/1/Source/core/dom/NodeListsNod...
File Source/core/dom/NodeListsNodeData.cpp (left):

https://codereview.chromium.org/390043003/diff/1/Source/core/dom/NodeListsNod...
Source/core/dom/NodeListsNodeData.cpp:32: #include
"core/timing/PerformanceEntry.h"
On 2014/07/14 17:29:26, adamk wrote:
> Unfortunate that git thinks this is a copy...maybe putting the shorter
copyright
> heading on this would fix that?

Yes, this is a straight move of code from NodeRareData.cpp and I am using the
exact same license header as in NodeRareData.cpp. If anything, using the same
license header increases the similarity between those 2 files. However, git
still thinks this file is more similar to PerformanceEntry.cpp :( Does it really
impact the git history? I thought this similarity thing was purely to facilitate
review (but I am no git expert).

[adamk, 2014-07-14 17:38:20]

On 2014/07/14 at 17:35:13, ch.dumez wrote:
>
https://codereview.chromium.org/390043003/diff/1/Source/core/dom/NodeListsNod...
> File Source/core/dom/NodeListsNodeData.cpp (left):
> 
>
https://codereview.chromium.org/390043003/diff/1/Source/core/dom/NodeListsNod...
> Source/core/dom/NodeListsNodeData.cpp:32: #include
"core/timing/PerformanceEntry.h"
> On 2014/07/14 17:29:26, adamk wrote:
> > Unfortunate that git thinks this is a copy...maybe putting the shorter
copyright
> > heading on this would fix that?
> 
> Yes, this is a straight move of code from NodeRareData.cpp and I am using the
exact same license header as in NodeRareData.cpp. If anything, using the same
license header increases the similarity between those 2 files. However, git
still thinks this file is more similar to PerformanceEntry.cpp :( Does it really
impact the git history? I thought this similarity thing was purely to facilitate
review (but I am no git expert).

No, it doesn't impact history, sorry for the noise (lgtm still :)

[Inactive, 2014-07-14 17:38:54]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-14 17:39:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/390043003/1

[commit-bot: I haz the power, 2014-07-14 18:45:23]

Change committed as 178090