Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8043)

Unified Diff: chrome/common/extensions/extension.cc

Issue 390019: Parse messages.json in ExtensionUnpacker (like we do for manifest).... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
===================================================================
--- chrome/common/extensions/extension.cc (revision 32098)
+++ chrome/common/extensions/extension.cc (working copy)
@@ -1103,6 +1103,14 @@
}
}
+ if (source.HasKey(keys::kDefaultLocale)) {
+ if (!source.GetString(keys::kDefaultLocale, &default_locale_) ||
+ default_locale_.empty()) {
+ *error = errors::kInvalidDefaultLocale;
+ return false;
+ }
+ }
+
// Chrome URL overrides (optional)
if (source.HasKey(keys::kChromeURLOverrides)) {
DictionaryValue* overrides;

Powered by Google App Engine
This is Rietveld 408576698