Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/browser/utility_process_host.h

Issue 390019: Parse messages.json in ExtensionUnpacker (like we do for manifest).... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/utility_process_host.h
===================================================================
--- chrome/browser/utility_process_host.h (revision 32098)
+++ chrome/browser/utility_process_host.h (working copy)
@@ -35,9 +35,11 @@
virtual void OnProcessCrashed() {}
// Called when the extension has unpacked successfully. |manifest| is the
- // parsed manifest.json file. |images| contains a list of decoded images
- // and the associated paths where those images live on disk.
- virtual void OnUnpackExtensionSucceeded(const DictionaryValue& manifest) {}
+ // parsed manifest.json file. |catalogs| contains list of all parsed
+ // message catalogs. |images| contains a list of decoded images and the
+ // associated paths where those images live on disk.
+ virtual void OnUnpackExtensionSucceeded(const DictionaryValue& manifest,
+ const DictionaryValue& catalogs) {}
// Called when an error occurred while unpacking the extension.
// |error_message| contains a description of the problem.
@@ -51,8 +53,7 @@
// Called when an error occurred while parsing the resource data.
// |error_message| contains a description of the problem.
- virtual void OnUnpackWebResourceFailed(
- const std::string& error_message) {}
+ virtual void OnUnpackWebResourceFailed(const std::string& error_message) {}
// Called when an update manifest xml file was successfully parsed.
virtual void OnParseUpdateManifestSucceeded(

Powered by Google App Engine
This is Rietveld 408576698