chrome/worker/webworkerclient_proxy.cc - Issue 390017: Added lifecycle management and sharing support for SharedWorkers. SharedWorkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/worker/webworkerclient_proxy.cc

Issue 390017: Added lifecycle management and sharing support for SharedWorkers. SharedWorkers (Closed)

Patch Set: Changed WebWorkerBase not not call a virtual function from the destructor Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/worker/webworkerclient_proxy.cc

diff --git a/chrome/worker/webworkerclient_proxy.cc b/chrome/worker/webworkerclient_proxy.cc

index 8519c23b33a4684cbd34afc6d951ece41dd26da3..6ba589f3afecb475eca6d0e39f67292118a50415 100644

--- a/chrome/worker/webworkerclient_proxy.cc

+++ b/chrome/worker/webworkerclient_proxy.cc

@@ -92,8 +92,7 @@ void WebWorkerClientProxy::reportPendingActivity(bool has_pending_activity) {

}

void WebWorkerClientProxy::workerContextClosed() {

- // TODO(atwilson): Notify WorkerProcessHost that the worker context is closing

- // (needed for shared workers so we don't allow new connections).

+ Send(new WorkerHostMsg_WorkerContextClosed(route_id_));

}

void WebWorkerClientProxy::workerContextDestroyed() {