Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 390013002: Use the same registers for StoreIC and KeyedStoreIC. (Closed)

Created:
6 years, 5 months ago by mvstanton
Modified:
6 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use the same registers for StoreIC and KeyedStoreIC. Based on https://codereview.chromium.org/389283002 ("Use register parameters in ElementsTransitionGenerator") which must land first. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -62 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm/ic-arm.cc View 3 chunks +22 lines, -7 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/arm64/ic-arm64.cc View 3 chunks +22 lines, -7 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 chunk +17 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ic.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Michael, here is an unchanged re-land of the CL you reviewed, it just requires ...
6 years, 5 months ago (2014-07-14 11:03:11 UTC) #1
Michael Starzinger
LGTM (rubber-stamped, since it's only a reland).
6 years, 5 months ago (2014-07-14 11:47:50 UTC) #2
mvstanton
6 years, 5 months ago (2014-07-14 20:43:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22387.

Powered by Google App Engine
This is Rietveld 408576698