Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 390003006: Merge 177250 "Initialize value since calculateFinalValues may fa..." (Closed)

Created:
6 years, 5 months ago by Raymond Toy
Modified:
6 years, 5 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Merge 177250 "Initialize value since calculateFinalValues may fa..." > Initialize value since calculateFinalValues may fail to do so. > > Fix threading issue where updateCoefficientsIfNecessary was not always > called from the audio thread. This causes the value not to be > initialized. > > Thus, > > o Initialize the variable to some value, just in case. > o Split updateCoefficientsIfNecessary into two functions with the code > that sets the coefficients pulled out in to the new function > updateCoefficients. > o Simplify updateCoefficientsIfNecessary since useSmoothing was always > true, and forceUpdate is not longer needed. > o Add process lock to prevent the audio thread from updating the > coefficients while they are being read in the main thread. The audio > thread will update them the next time around. > o Make getFrequencyResponse set the lock while reading the > coefficients of the biquad in preparation for computing the > frequency response. > > BUG=389219 > > Review URL: https://codereview.chromium.org/354213002 TBR=rtoy@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -60 lines) Patch
M Source/modules/webaudio/AudioParam.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/BiquadDSPKernel.h View 1 chunk +7 lines, -6 lines 0 comments Download
M Source/modules/webaudio/BiquadDSPKernel.cpp View 3 chunks +81 lines, -53 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raymond Toy
6 years, 5 months ago (2014-07-14 23:13:54 UTC) #1
Raymond Toy
6 years, 5 months ago (2014-07-14 23:14:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r178109 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698