Fix crash bug with noSuchMethod invocation and argument count mismatch.

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "platform/utils.h"
 #include "vm/bootstrap.h"
 #include "vm/class_finalizer.h"
@@ skipping 1359 matching lines @@
         Array::ZoneHandle(I, Array::New(desc.NamedCount()));
     for (intptr_t i = 0; i < arg_names.Length(); ++i) {
       arg_names.SetAt(i, String::Handle(I, desc.NameAt(i)));
     }
     func_args->set_names(arg_names);
   }
 
   const String& func_name = String::ZoneHandle(I, func.name());
   ArgumentListNode* arguments = BuildNoSuchMethodArguments(
       token_pos, func_name, *func_args, NULL, false);
-  const Function& no_such_method = Function::ZoneHandle(I,
-      Resolver::ResolveDynamicAnyArgs(Class::Handle(
-          I, func.Owner()), Symbols::NoSuchMethod()));
+  const intptr_t kNumArguments = 2;  // Receiver, InvocationMirror.
+  ArgumentsDescriptor args_desc(
+      Array::Handle(I, ArgumentsDescriptor::New(kNumArguments)));
+  Function& no_such_method = Function::ZoneHandle(I,
+      Resolver::ResolveDynamicForReceiverClass(Class::Handle(I, func.Owner()),
+                                               Symbols::NoSuchMethod(),
+                                               args_desc));
+  if (no_such_method.IsNull()) {
+    // If noSuchMethod(i) is not found, call Object:noSuchMethod.
+  no_such_method ^= Resolver::ResolveDynamicForReceiverClass(

[Ivan Posva, 2014/07/14 10:03:19]

Indentation.

[Florian Schneider, 2014/07/14 10:06:20]

Done.

+      Class::Handle(I, I->object_store()->object_class()),
+      Symbols::NoSuchMethod(),
+      args_desc);
+  }
   StaticCallNode* call =
       new StaticCallNode(token_pos, no_such_method, arguments);
 
   ReturnNode* return_node = new ReturnNode(token_pos, call);
   current_block_->statements->Add(return_node);
   return CloseBlock();
 }
 
 
 SequenceNode* Parser::ParseInvokeFieldDispatcher(const Function& func,
@@ skipping 9666 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart