Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 389993002: Teach WebURLRequest about Fetch's "frame type" concept. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, gavinp+loader_chromium.org, jamesr, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Teach WebURLRequest about Fetch's "frame type" concept. This CL introduces a new enum property on resource requests which maps to the "frame type" concept in Fetch[1]. The eventual goal is to migrate mixed content and CSP checks which rely on knowledge of a request's browsing context to use this new property rather than overloading the request context with information about the request's browsing context and originator. To ensure that we can rely on the property's value, we ASSERT that the value is properly set when loading "main" resources. [1]: http://fetch.spec.whatwg.org/#concept-request-context-frame-type BUG=390497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178069

Patch Set 1 #

Patch Set 2 : Missed one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 5 chunks +13 lines, -3 lines 0 comments Download
M Source/platform/exported/WebURLRequest.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebURLRequest.h View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mike West
Mind taking a look at this, Jochen? It should have zero web-visible effect, as it's ...
6 years, 5 months ago (2014-07-14 09:34:54 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-14 10:47:12 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-14 12:26:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/389993002/20001
6 years, 5 months ago (2014-07-14 12:27:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-14 13:34:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 14:29:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/15312)
6 years, 5 months ago (2014-07-14 14:29:06 UTC) #7
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-14 14:53:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/389993002/20001
6 years, 5 months ago (2014-07-14 14:54:52 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 15:38:05 UTC) #10
Message was sent while issue was closed.
Change committed as 178069

Powered by Google App Engine
This is Rietveld 408576698