[SyncFS] Interface clean up around LocalfileSyncContext::GetFileForLocalSync

chrome/browser/sync_file_system/local/local_file_sync_context.h

Index: chrome/browser/sync_file_system/local/local_file_sync_context.h
diff --git a/chrome/browser/sync_file_system/local/local_file_sync_context.h b/chrome/browser/sync_file_system/local/local_file_sync_context.h
index be97f5dfa92bfd85c3fd53357d1bde1d3b2b10ce..0decd08b2c5573a808e7c21cc055f679ca0745c5 100644
--- a/chrome/browser/sync_file_system/local/local_file_sync_context.h
+++ b/chrome/browser/sync_file_system/local/local_file_sync_context.h
@@ -216,6 +216,7 @@ class LocalFileSyncContext
  private:
   typedef base::Callback<void(base::File::Error result)> StatusCallback;
   typedef std::deque<SyncStatusCallback> StatusCallbackQueue;

[peria, 2014/07/14 10:08:37]

How about using std::queue instead of std::deque, if push_front() or pop_back()
are not used?

[tzik, 2014/07/14 10:23:36]

My next CL is going to iterate over this, so it can't be a std::queue.

+  typedef std::deque<fileapi::FileSystemURL> FileSystemURLQueue;

[peria, 2014/07/14 10:08:37]

ditto

   friend class base::RefCountedThreadSafe<LocalFileSyncContext>;
   friend class CannedSyncableFileSystem;
 
@@ -257,16 +258,15 @@ class LocalFileSyncContext
       SyncStatusCode status);
 
   // Helper routines for GetFileForLocalSync.
-  void GetNextURLsForSyncOnFileThread(
-      fileapi::FileSystemContext* file_system_context,
-      std::deque<fileapi::FileSystemURL>* urls);
+  scoped_ptr<FileSystemURLQueue> GetNextURLsForSyncOnFileThread(
+      fileapi::FileSystemContext* file_system_context);
   void TryPrepareForLocalSync(
       fileapi::FileSystemContext* file_system_context,
-      std::deque<fileapi::FileSystemURL>* urls,
-      const LocalFileSyncInfoCallback& callback);
+      const LocalFileSyncInfoCallback& callback,
+      scoped_ptr<FileSystemURLQueue> urls);
   void DidTryPrepareForLocalSync(
       fileapi::FileSystemContext* file_system_context,
-      std::deque<fileapi::FileSystemURL>* remaining_urls,
+      scoped_ptr<FileSystemURLQueue> remaining_urls,
       const LocalFileSyncInfoCallback& callback,
       SyncStatusCode status,
       const LocalFileSyncInfo& sync_file_info,