Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 389983002: [SyncFS] Interface clean up around LocalfileSyncContext::GetFileForLocalSync (Closed)

Created:
6 years, 5 months ago by tzik
Modified:
6 years, 5 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Interface clean up around LocalfileSyncContext::GetFileForLocalSync BUG=344769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282940

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M chrome/browser/sync_file_system/local/local_file_sync_context.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 1 5 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tzik
PTL
6 years, 5 months ago (2014-07-14 09:30:46 UTC) #1
peria
https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_system/local/local_file_sync_context.cc File chrome/browser/sync_file_system/local/local_file_sync_context.cc (right): https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_system/local/local_file_sync_context.cc#newcode776 chrome/browser/sync_file_system/local/local_file_sync_context.cc:776: } no return https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_system/local/local_file_sync_context.h File chrome/browser/sync_file_system/local/local_file_sync_context.h (right): https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_system/local/local_file_sync_context.h#newcode218 chrome/browser/sync_file_system/local/local_file_sync_context.h:218: ...
6 years, 5 months ago (2014-07-14 10:08:37 UTC) #2
tzik
https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_system/local/local_file_sync_context.cc File chrome/browser/sync_file_system/local/local_file_sync_context.cc (right): https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_system/local/local_file_sync_context.cc#newcode776 chrome/browser/sync_file_system/local/local_file_sync_context.cc:776: } On 2014/07/14 10:08:37, peria wrote: > no return ...
6 years, 5 months ago (2014-07-14 10:23:36 UTC) #3
peria
lgtm
6 years, 5 months ago (2014-07-14 10:26:43 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 5 months ago (2014-07-14 11:19:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/389983002/20001
6 years, 5 months ago (2014-07-14 11:20:00 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 13:23:43 UTC) #7
Message was sent while issue was closed.
Change committed as 282940

Powered by Google App Engine
This is Rietveld 408576698