[SyncFS] Interface clean up around LocalfileSyncContext::GetFileForLocalSync

[SyncFS] Interface clean up around LocalfileSyncContext::GetFileForLocalSync

BUG=344769
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282940

[tzik, 2014-07-14 09:30:46]

PTL

[peria, 2014-07-14 10:08:37]

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_context.cc (right):

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_context.cc:776: }
no return

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_context.h (right):

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_context.h:218: typedef
std::deque<SyncStatusCallback> StatusCallbackQueue;
How about using std::queue instead of std::deque, if push_front() or pop_back()
are not used?

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_context.h:219: typedef
std::deque<fileapi::FileSystemURL> FileSystemURLQueue;
ditto

[tzik, 2014-07-14 10:23:36]

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_context.cc (right):

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_context.cc:776: }
On 2014/07/14 10:08:37, peria wrote:
> no return

Done.
It's surprising that this code has passed the compilation locally.

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_context.h (right):

https://codereview.chromium.org/389983002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_context.h:218: typedef
std::deque<SyncStatusCallback> StatusCallbackQueue;
On 2014/07/14 10:08:37, peria wrote:
> How about using std::queue instead of std::deque, if push_front() or
pop_back()
> are not used?

My next CL is going to iterate over this, so it can't be a std::queue.

[peria, 2014-07-14 10:26:43]

lgtm

[tzik, 2014-07-14 11:19:05]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-14 11:20:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/389983002/20001

[commit-bot: I haz the power, 2014-07-14 13:23:43]

Change committed as 282940