Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 38993005: Add isolate parameter to SetResourceConstraints, and deprecate version which depends on current iso… (Closed)

Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 1 month ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add isolate parameter to SetResourceConstraints, and deprecate version which depends on current isolate. BUG=None R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17509

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change argument order. #

Patch Set 3 : Update comment too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M include/v8.h View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M src/api.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmcilroy
I'll remove the deprecated version once this has rolled and I've updated Blink to use ...
7 years, 2 months ago (2013-10-24 13:52:01 UTC) #1
Benedikt Meurer
LGTM with nit https://codereview.chromium.org/38993005/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/38993005/diff/1/include/v8.h#newcode3800 include/v8.h:3800: Isolate* isolate); nit: Change order of ...
7 years, 2 months ago (2013-10-24 17:52:05 UTC) #2
rmcilroy
https://codereview.chromium.org/38993005/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/38993005/diff/1/include/v8.h#newcode3800 include/v8.h:3800: Isolate* isolate); On 2013/10/24 17:52:06, Benedikt Meurer wrote: > ...
7 years, 1 month ago (2013-10-29 12:42:17 UTC) #3
rmcilroy
On 2013/10/29 12:42:17, rmcilroy wrote: > https://codereview.chromium.org/38993005/diff/1/include/v8.h > File include/v8.h (right): > > https://codereview.chromium.org/38993005/diff/1/include/v8.h#newcode3800 > ...
7 years, 1 month ago (2013-11-05 13:45:26 UTC) #4
rmcilroy
On 2013/11/05 13:45:26, rmcilroy wrote: > On 2013/10/29 12:42:17, rmcilroy wrote: > > https://codereview.chromium.org/38993005/diff/1/include/v8.h > ...
7 years, 1 month ago (2013-11-05 13:46:18 UTC) #5
Benedikt Meurer
7 years, 1 month ago (2013-11-06 06:59:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r17509.

Powered by Google App Engine
This is Rietveld 408576698