Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h

Issue 389913002: Moving IME manifests to chrome resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h
diff --git a/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h b/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h
index 913987ae10ecf9a340a4b650832137db5a97d3ab..493d2e3caa4a52168a5d11deff6b12465aaf6eb9 100644
--- a/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h
+++ b/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h
@@ -32,14 +32,6 @@ class ComponentExtensionIMEManagerImpl
virtual void Unload(const std::string& extension_id,
const base::FilePath& file_path) OVERRIDE;
- // Loads extension list and reads their manifest file. After finished
- // initialization, |callback| will be called on original thread.
- void InitializeAsync(const base::Closure& callback);
-
- // Returns true if this class is initialized and ready to use, otherwise
- // returns false.
- bool IsInitialized();
-
private:
// Reads component extensions and extract their localized information: name,
// description and ime id. This function fills them into |out_imes|. This
@@ -47,15 +39,10 @@ class ComponentExtensionIMEManagerImpl
static void ReadComponentExtensionsInfo(
std::vector<ComponentExtensionIME>* out_imes);
- // This function is called on UI thread after ReadComponentExtensionsInfo
- // function is finished. No need to release |result|.
- void OnReadComponentExtensionsInfo(std::vector<ComponentExtensionIME>* result,
- const base::Closure& callback);
-
// Reads manifest.json file in |file_path|. This function must be called on
// file thread.
Alexander Alekseev 2014/07/14 14:07:29 Is this comment still valid: "must be called on fi
Shu Chen 2014/07/14 15:07:21 Done.
static scoped_ptr<base::DictionaryValue> GetManifest(
- const base::FilePath& file_path);
+ const std::string& manifest_string);
// Reads extension information: description, option page. This function
// returns true on success, otherwise returns false. This function must be
@@ -72,9 +59,6 @@ class ComponentExtensionIMEManagerImpl
const base::DictionaryValue& dict,
ComponentExtensionEngine* out);
- // True if initialized.
- bool is_initialized_;
-
// The list of component extension IME.
std::vector<ComponentExtensionIME> component_extension_list_;

Powered by Google App Engine
This is Rietveld 408576698