Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chromeos/ime/component_extension_ime_manager.h

Issue 389913002: Moving IME manifests to chrome resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed duplicated XKB extension loading. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/component_extension_ime_manager.h
diff --git a/chromeos/ime/component_extension_ime_manager.h b/chromeos/ime/component_extension_ime_manager.h
index 11f113f9e0b1750d83e1b258579504bd64936e69..c455712d8f32ad952bc88df7cdb87b53e78682f8 100644
--- a/chromeos/ime/component_extension_ime_manager.h
+++ b/chromeos/ime/component_extension_ime_manager.h
@@ -63,12 +63,6 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManagerDelegate {
// This class manages component extension input method.
class CHROMEOS_EXPORT ComponentExtensionIMEManager {
public:
- class Observer {
- public:
- // Called when the initialization is done.
- virtual void OnImeComponentExtensionInitialized() = 0;
- };
-
ComponentExtensionIMEManager();
virtual ~ComponentExtensionIMEManager();
@@ -77,12 +71,6 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
// be called before using any other function.
void Initialize(scoped_ptr<ComponentExtensionIMEManagerDelegate> delegate);
- // Notifies the observers for the component extension IMEs are initialized.
- void NotifyInitialized();
-
- // Returns true if the initialization is done, otherwise returns false.
- bool IsInitialized();
-
// Loads |input_method_id| component extension IME. This function returns true
// on success. This function is safe to call multiple times. Returns false if
// already corresponding component extension is loaded.
@@ -120,9 +108,6 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
// Returns all XKB keyboard IME as InputMethodDescriptors.
input_method::InputMethodDescriptors GetXkbIMEAsInputMethodDescriptor();
- void AddObserver(Observer* observer);
- void RemoveObserver(Observer* observer);
-
private:
// Finds ComponentExtensionIME and EngineDescription associated with
// |input_method_id|. This function retruns true if it is found, otherwise
@@ -137,12 +122,6 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
std::vector<ComponentExtensionIME> component_extension_imes_;
- ObserverList<Observer> observers_;
-
- bool is_initialized_;
-
- bool was_initialization_notified_;
-
std::set<std::string> login_layout_set_;
DISALLOW_COPY_AND_ASSIGN(ComponentExtensionIMEManager);

Powered by Google App Engine
This is Rietveld 408576698