Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6447)

Unified Diff: chrome/browser/resources/options/language_options.js

Issue 389913002: Moving IME manifests to chrome resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed duplicated XKB extension loading. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_options.js
diff --git a/chrome/browser/resources/options/language_options.js b/chrome/browser/resources/options/language_options.js
index 5ebf910b17c23f2087232488e2b5daf76b1d5bd0..c6cbeb8ec9797a84a5e3bca5db03a5c23055990c 100644
--- a/chrome/browser/resources/options/language_options.js
+++ b/chrome/browser/resources/options/language_options.js
@@ -196,7 +196,7 @@ cr.define('options', function() {
loadTimeData.getValue('translateSupportedLanguages');
// Set up add button.
- $('language-options-add-button').onclick = function(e) {
+ var onclick = function(e) {
// Add the language without showing the overlay if it's specified in
// the URL hash (ex. lang_add=ja). Used for automated testing.
var match = document.location.hash.match(/\blang_add=([\w-]+)/);
@@ -207,7 +207,8 @@ cr.define('options', function() {
} else {
OptionsPage.navigateToPage('addLanguage');
}
- }.bind(this);
+ };
+ $('language-options-add-button').onclick = onclick.bind(this);
if (!cr.isMac) {
// Set up the button for editing custom spelling dictionary.
@@ -334,7 +335,8 @@ cr.define('options', function() {
button.inputMethodId = inputMethod.id;
button.onclick = function(inputMethodId, e) {
chrome.send('inputMethodOptionsOpen', [inputMethodId]);
- }.bind(this, inputMethod.id);
+ };
+ button.onclick = button.onclick.bind(this, inputMethod.id);
element.appendChild(button);
}
@@ -1358,10 +1360,6 @@ cr.define('options', function() {
LanguageOptions.getInstance().onDictionaryDownloadFailure_(languageCode);
};
- LanguageOptions.onComponentManagerInitialized = function(componentImes) {
- LanguageOptions.getInstance().appendComponentExtensionIme_(componentImes);
- };
-
// Export
return {
LanguageOptions: LanguageOptions

Powered by Google App Engine
This is Rietveld 408576698