Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3348)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 389913002: Moving IME manifests to chrome resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index 88028bc25a03bf336524f48e8a1e81f5b257e600..aecc2aa3ae687998f7401be0b7c252c5c80fed8a 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -162,12 +162,6 @@ class DBusServices {
TPMTokenLoader::Initialize();
CertLoader::Initialize();
- // This function and SystemKeyEventListener use InputMethodManager.
- chromeos::input_method::Initialize(
- content::BrowserThread::GetMessageLoopProxyForThread(
- content::BrowserThread::UI),
- content::BrowserThread::GetMessageLoopProxyForThread(
- content::BrowserThread::FILE));
disks::DiskMountManager::Initialize();
cryptohome::AsyncMethodCaller::Initialize();
cryptohome::HomedirMethods::Initialize();
@@ -184,13 +178,6 @@ class DBusServices {
// detector starts to monitor changes from the update engine.
UpgradeDetectorChromeos::GetInstance()->Init();
- if (base::SysInfo::IsRunningOnChromeOS()) {
- // Disable Num Lock on X start up for http://crosbug.com/29169.
- input_method::InputMethodManager::Get()
- ->GetImeKeyboard()
- ->DisableNumLock();
- }
-
// Initialize the device settings service so that we'll take actions per
// signals sent from the session manager. This needs to happen before
// g_browser_process initializes BrowserPolicyConnector.
@@ -206,7 +193,6 @@ class DBusServices {
cryptohome::AsyncMethodCaller::Shutdown();
disks::DiskMountManager::Shutdown();
- input_method::Shutdown();
SystemSaltGetter::Shutdown();
LoginState::Shutdown();
@@ -365,6 +351,9 @@ void ChromeBrowserMainPartsChromeos::PreProfileInit() {
// notification it needs to track the logged in user.
g_browser_process->profile_manager();
+ // AccessibilityManager and SystemKeyEventListener use InputMethodManager.
+ input_method::Initialize();
+
// ProfileHelper has to be initialized after UserManager instance is created.
ProfileHelper::Get()->Initialize();
@@ -714,6 +703,8 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
// Ash needs to be closed before UserManager is destroyed.
ChromeBrowserMainPartsLinux::PostMainMessageLoopRun();
+ input_method::Shutdown();
Nico 2014/07/22 17:05:08 (nit: as a verb, I think it's two words: "shut dow
Shu Chen 2014/07/23 00:56:45 For the naming, all the shutdown methods around ar
+
// Stops all in-flight OAuth2 token fetchers before the IO thread stops.
DeviceOAuth2TokenServiceFactory::Shutdown();

Powered by Google App Engine
This is Rietveld 408576698