Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.h

Issue 389913002: Moving IME manifests to chrome resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.h
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.h b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
index c8117dc8c9446787a407ffc7bb23e73c9ddc1e02..927a2b8be13e60934f1d79c0dc2856927eab98bf 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.h
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
@@ -35,16 +35,11 @@ class InputMethodManagerImpl : public InputMethodManager,
explicit InputMethodManagerImpl(scoped_ptr<InputMethodDelegate> delegate);
virtual ~InputMethodManagerImpl();
- // Attach CandidateWindowController, and ImeKeyboard objects to the
- // InputMethodManagerImpl object. You don't have to call this
- // function if you attach them yourself (e.g. in unit tests) using
- // the protected setters.
- void Init(base::SequencedTaskRunner* ui_task_runner);
-
// Receives notification of an InputMethodManager::State transition.
void SetState(State new_state);
// InputMethodManager override:
+ virtual void InitializeComponentExtension() OVERRIDE;
virtual void AddObserver(InputMethodManager::Observer* observer) OVERRIDE;
virtual void AddCandidateWindowObserver(
InputMethodManager::CandidateWindowObserver* observer) OVERRIDE;
@@ -144,14 +139,9 @@ class InputMethodManagerImpl : public InputMethodManager,
bool ChangeInputMethodInternal(const std::string& input_method_id,
bool show_message);
- // Gets whether the XKB extension is loaded successfully by checking the XKB
- // input methods in input methods in |component_extension_ime_manager_|.
- bool IsXkbComponentExtensionAvailable() const;
-
// Called when the ComponentExtensionIMEManagerDelegate is initialized.
void OnComponentExtensionInitialized(
scoped_ptr<ComponentExtensionIMEManagerDelegate> delegate);
- void InitializeComponentExtension();
// Loads necessary component extensions.
// TODO(nona): Support dynamical unloading.
@@ -202,9 +192,6 @@ class InputMethodManagerImpl : public InputMethodManager,
// message is sent.
scoped_ptr<CandidateWindowController> candidate_window_controller_;
- // The object which can create an InputMethodDescriptor object.
- InputMethodWhitelist whitelist_;
-
// An object which provides miscellaneous input method utility functions. Note
// that |util_| is required to initialize |keyboard_|.
InputMethodUtil util_;

Powered by Google App Engine
This is Rietveld 408576698