Issue 389903002: Split V8RecursionScope into core and modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389903002: Split V8RecursionScope into core and modules. (Closed)

Created:
6 years, 5 months ago by tasak

Modified:
6 years, 5 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Split V8RecursionScope into core and modules. Register didLeaveScriptContext for modules with ModuleProxy and invoke the function in V8RecursionScope::didLeaveScriptContext() in core. BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178035

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -5 lines)			Patch
M	Source/bindings/core/v8/ModuleProxy.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/bindings/core/v8/ModuleProxy.cpp	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	Source/bindings/core/v8/V8RecursionScope.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	Source/bindings/modules/v8/ModuleBindingsInitializer.cpp	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/389903002/1

6 years, 5 months ago (2014-07-14 07:50:14 UTC) #4

Message was sent while issue was closed.

Change committed as 178035

Expand Messages | Collapse Messages