Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: crosstest/mem_intrin.h

Issue 389683003: Remove memcpy test workaround for name mangling substitutions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | crosstest/mem_intrin.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crosstest/mem_intrin.h
diff --git a/crosstest/mem_intrin.h b/crosstest/mem_intrin.h
index 97e6dccabef0bdf574775f423bd140f2085781c5..70f02ae7394da5292736e3fc44daf410239d5185 100644
--- a/crosstest/mem_intrin.h
+++ b/crosstest/mem_intrin.h
@@ -5,14 +5,9 @@
* under different namespaces.
*/
-/* Declare first buf as uint8_t * and second as void *, to avoid C++
- * name mangling's use of substitutions. Otherwise Subzero's name
- * mangling injection will need to bump each substitution sequence ID
- * up by one (e.g., from S_ to S0_ and S1_ to S2_).
- */
-int memcpy_test(uint8_t *buf, void *buf2, uint8_t init, size_t length);
-int memmove_test(uint8_t *buf, void *buf2, uint8_t init, size_t length);
-int memset_test(uint8_t *buf, void *buf2, uint8_t init, size_t length);
+int memcpy_test(uint8_t *buf, uint8_t *buf2, uint8_t init, size_t length);
+int memmove_test(uint8_t *buf, uint8_t *buf2, uint8_t init, size_t length);
+int memset_test(uint8_t *buf, uint8_t *buf2, uint8_t init, size_t length);
int memcpy_test_fixed_len(uint8_t init);
int memmove_test_fixed_len(uint8_t init);
« no previous file with comments | « no previous file | crosstest/mem_intrin.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698