Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 389683003: Remove memcpy test workaround for name mangling substitutions. (Closed)

Created:
6 years, 5 months ago by jvoung (off chromium)
Modified:
6 years, 5 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Remove memcpy test workaround for name mangling substitutions. Now that the name mangling is a bit smarter (from commit: 217dc082d5cc2af1cc7c544f51ef15b4abe5be8b), we don't need to avoid having the same type twice in the function signature. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=140bb0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -23 lines) Patch
M crosstest/mem_intrin.h View 1 chunk +3 lines, -8 lines 0 comments Download
M crosstest/mem_intrin.cpp View 2 chunks +12 lines, -13 lines 0 comments Download
M crosstest/mem_intrin_main.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvoung (off chromium)
6 years, 5 months ago (2014-07-14 18:10:32 UTC) #1
Jim Stichnoth
Cool, lgtm.
6 years, 5 months ago (2014-07-14 18:34:45 UTC) #2
jvoung (off chromium)
6 years, 5 months ago (2014-07-14 18:51:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r140bb0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698