content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 389683002: Improving GestureNav screenshotting performance - part 2 - GestureNav

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 389683002: Improving GestureNav screenshotting performance - part 2 - GestureNav (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@slow_readback_final_GL_HELPER

Patch Set: Fixing NavigationControllerTest.PurgeScreenshot in content_unittests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/delegated_frame_host.cc ('k') | content/browser/frame_host/navigation_entry_screenshot_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index eab04fdad186600b0a20af43d17c1da50fc9a667..854b29ee5d8238940d2c1efb2e2b70adbdd6fb9b 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -78,7 +78,8 @@ class MockScreenshotManager : public content::NavigationEntryScreenshotManager {

void TakeScreenshotFor(content::NavigationEntryImpl* entry) {

SkBitmap bitmap;

- bitmap.allocN32Pixels(1, 1);

+ bitmap.allocPixels(SkImageInfo::Make(

+ 1, 1, kAlpha_8_SkColorType, kPremul_SkAlphaType));

bitmap.eraseARGB(0, 0, 0, 0);

encoding_screenshot_in_progress_ = true;

OnScreenshotTaken(entry->GetUniqueID(), true, bitmap);