Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: remoting/webapp/browser_test/update_pin_browser_test.js

Issue 389673003: Handle host need upgrade in Pin browser test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Jamie's feedbacks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/browser_test/update_pin_browser_test.js
diff --git a/remoting/webapp/browser_test/update_pin_browser_test.js b/remoting/webapp/browser_test/update_pin_browser_test.js
index 0d0eba5fa40a164de3480ce57240d798514e1f7e..7eed5aa14d3a612884fb79f1e265af2cfee6655b 100644
--- a/remoting/webapp/browser_test/update_pin_browser_test.js
+++ b/remoting/webapp/browser_test/update_pin_browser_test.js
@@ -27,14 +27,14 @@ browserTest.Update_PIN.prototype.run = function(data) {
'The new PIN and the old PIN cannot be the same');
this.changePIN_(data.new_pin).then(
- this.connect_.bind(this)
+ browserTest.connectMe2Me
).then(
this.enterPIN_.bind(this, data.old_pin, true /* expectError*/)
).then(
// Sleep for two seconds to allow for the login backoff logic to reset.
base.Promise.sleep.bind(null, LOGIN_BACKOFF_WAIT)
).then(
- this.connect_.bind(this)
+ browserTest.connectMe2Me
).then(
this.enterPIN_.bind(this, data.new_pin, false /* expectError*/)
).then(
@@ -72,11 +72,6 @@ browserTest.Update_PIN.prototype.changePIN_ = function(newPin) {
});
};
-browserTest.Update_PIN.prototype.connect_ = function() {
- browserTest.clickOnControl('this-host-connect');
- return browserTest.onUIMode(remoting.AppMode.CLIENT_PIN_PROMPT);
-};
-
browserTest.Update_PIN.prototype.disconnect_ = function() {
var AppMode = remoting.AppMode;

Powered by Google App Engine
This is Rietveld 408576698