Issue 389663004: [Resources] Fix promo.html to navigate to fragments instead of a real link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389663004: [Resources] Fix promo.html to navigate to fragments instead of a real link (Closed)

Created:
6 years, 5 months ago by Mathieu

Modified:
6 years, 5 months ago

Reviewers:
beaudoin, beaudoin1

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Resources] Fix promo.html to navigate to fragments instead of a real link R=beaudoin@chromium.org, beaudoin@google.com TBR=jered BUG=374932 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282665

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	chrome/browser/resources/contextual_search/promo.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/search/contextual_search_promo_source.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

beaudoin1

Nit: I think they're called "fragments" or "named anchor" not "hashes". LGTM

6 years, 5 months ago (2014-07-11 19:13:55 UTC) #1

Mathieu

6 years, 5 months ago (2014-07-11 19:36:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r282665 (presubmit successful).

Expand Messages | Collapse Messages