Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 389663003: aura: Remove WindowTreeHost::OnDeviceScaleFactorChanged. (Closed)

Created:
6 years, 5 months ago by sadrul
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tdanderson+views_chromium.org, ben+aura_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org, ben+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

aura: Remove WindowTreeHost::OnDeviceScaleFactorChanged. None of the implementations if WindowTreeHosts do anything when the device-scale factor changes. So remove it. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282799

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
M mojo/aura/window_tree_host_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/services/view_manager/window_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/view_manager/window_tree_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/window.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/aura/window_tree_host_ozone.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_ozone.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/window_tree_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 5 months ago (2014-07-11 20:45:04 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-11 22:04:21 UTC) #2
sadrul
6 years, 5 months ago (2014-07-12 04:50:50 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r282799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698