Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 389653005: Introduce task_runner() accessors for both base::Thread and base::MessageLoop (Closed)

Created:
6 years, 5 months ago by Ryan Sleevi
Modified:
6 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Project:
chromium
Visibility:
Public.

Description

Introduce task_runner() accessors for both base::Thread and base::MessageLoop This is so that callers can code against a TaskRunner interface directly, rather than converting message_loop_proxy() into a TaskRunner. BUG=391045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282767

Patch Set 1 #

Patch Set 2 : Drop header #

Total comments: 1

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M base/message_loop/message_loop.h View 1 chunk +7 lines, -0 lines 0 comments Download
M base/threading/thread.h View 1 2 1 chunk +17 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Sleevi
To make cleanup easier for the messy parts
6 years, 5 months ago (2014-07-11 20:21:33 UTC) #1
awong
just a nit https://codereview.chromium.org/389653005/diff/20001/base/threading/thread.h File base/threading/thread.h (right): https://codereview.chromium.org/389653005/diff/20001/base/threading/thread.h#newcode154 base/threading/thread.h:154: // methods to execute code on ...
6 years, 5 months ago (2014-07-11 20:23:18 UTC) #2
Ryan Sleevi
On 2014/07/11 20:23:18, awong wrote: > just a nit > > https://codereview.chromium.org/389653005/diff/20001/base/threading/thread.h > File base/threading/thread.h ...
6 years, 5 months ago (2014-07-11 20:24:05 UTC) #3
Ryan Sleevi
Updated comments
6 years, 5 months ago (2014-07-11 20:26:30 UTC) #4
awong
LGTM
6 years, 5 months ago (2014-07-11 20:30:05 UTC) #5
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 5 months ago (2014-07-11 20:30:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/389653005/40001
6 years, 5 months ago (2014-07-11 20:32:27 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 01:11:00 UTC) #8
Message was sent while issue was closed.
Change committed as 282767

Powered by Google App Engine
This is Rietveld 408576698