Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: dm/DM.cpp

Issue 389653004: share dm and command flags (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dm/DMReporter.cpp » ('j') | tests/skia_test.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index afe75734e981724c4d07238c5ad2cdb8b3a638b9..777d924aa16f2bf743cb5f952e8589e617ff4342 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -3,7 +3,7 @@
#include "Benchmark.h"
#include "CrashHandler.h"
-#include "SkCommandLineFlags.h"
+#include "SkCommonFlags.h"
#include "SkForceLinking.h"
#include "SkGraphics.h"
#include "SkPicture.h"
@@ -40,7 +40,6 @@ using skiatest::TestRegistry;
static const char kGpuAPINameGL[] = "gl";
static const char kGpuAPINameGLES[] = "gles";
-DEFINE_int32(threads, -1, "Threads for CPU work. Default NUM_CPUS.");
DEFINE_int32(gpuThreads, 1, "Threads for GPU work.");
DEFINE_string(gpuAPI, "", "Force use of specific gpu API. Using \"gl\" "
"forces OpenGL API. Using \"gles\" forces OpenGL ES API. "
@@ -50,29 +49,16 @@ DEFINE_string2(expectations, r, "",
"If a directory, compare generated images against images under this path. "
"If a file, compare generated images against JSON expectations at this path."
);
-DEFINE_string2(resources, i, "resources", "Path to resources directory.");
-DEFINE_string(match, "", "[~][^]substring[$] [...] of GM name to run.\n"
- "Multiple matches may be separated by spaces.\n"
- "~ causes a matching GM to always be skipped\n"
- "^ requires the start of the GM to match\n"
- "$ requires the end of the GM to match\n"
- "^ and $ requires an exact match\n"
- "If a GM does not match any list entry,\n"
- "it is skipped unless some list entry starts with ~");
+
DEFINE_string(config, "565 8888 pdf gpu nonrendering",
"Options: 565 8888 pdf gpu nonrendering msaa4 msaa16 nvprmsaa4 nvprmsaa16 "
"gpunull gpudebug angle mesa");
-DEFINE_bool(dryRun, false,
- "Just print the tests that would be run, without actually running them.");
-DEFINE_bool(leaks, false, "Print leaked instance-counted objects at exit?");
DEFINE_string(skps, "", "Directory to read skps from.");
DEFINE_bool(gms, true, "Run GMs?");
DEFINE_bool(benches, true, "Run benches? Does not run GMs-as-benches.");
DEFINE_bool(tests, true, "Run tests?");
-DECLARE_bool(verbose);
-
__SK_FORCE_IMAGE_DECODER_LINKING;
// "FooBar" -> "foobar". Obviously, ASCII only.
@@ -234,11 +220,10 @@ static void append_matching_factories(Registry* head, SkTDArray<typename Registr
}
}
-int tool_main(int argc, char** argv);
-int tool_main(int argc, char** argv) {
+int dm_main(int argc, char** argv);
+int dm_main(int argc, char** argv) {
scroggo 2014/07/14 13:24:16 argc and argv are no longer used.
caryclark 2014/07/14 15:07:12 Done.
SetupCrashHandler();
SkAutoGraphics ag;
- SkCommandLineFlags::Parse(argc, argv);
if (FLAGS_dryRun) {
FLAGS_verbose = true;
@@ -299,6 +284,7 @@ int tool_main(int argc, char** argv) {
#if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
int main(int argc, char** argv) {
- return tool_main(argc, argv);
+ SkCommandLineFlags::Parse(argc, argv);
+ return dm_main(argc, argv);
}
#endif
« no previous file with comments | « no previous file | dm/DMReporter.cpp » ('j') | tests/skia_test.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698