extensions/browser/DEPS - Issue 389633002: Move system.* family of APIs to extensions/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/DEPS

Issue 389633002: Move system.* family of APIs to extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed gn build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+ash",
	Daniel Erat 2014/07/17 13:51:52 extensions/browser/ shouldn't depend on ash/. the extensions/browser/ shouldn't depend on ash/. the code that needs this should probably use a delegate that can be passed in from outside. tmpsantos 2014/07/17 14:39:04 The idea of the display_info_provider_[platform].c Show quoted text On 2014/07/17 13:51:52, Daniel Erat wrote: > extensions/browser/ shouldn't depend on ash/. the code that needs this should > probably use a delegate that can be passed in from outside. The idea of the display_info_provider_[platform].cc is to handle the platform specific bits, that is why it is talking directly to the window manager instead of going through layers of indirection. If we don't do this here, the same delegate would need to be implemented for Chrome and app_shell (win/mac/linux/etc). If the dependency on ash/ is still not acceptable, is it possible to fix this in a separated CL? That would require a big refactoring of display_info_provider_chromeos.cc which is not exactly related to this change.
2 "+components/keyed_service",	3 "+components/keyed_service",

3 "+components/pref_registry",	4 "+components/pref_registry",

	5 "+components/storage_monitor",

4 "+content/public/browser",	6 "+content/public/browser",

5 "+grit/extensions_strings.h",	7 "+grit/extensions_strings.h",

6 "+net",	8 "+net",

7 "+skia/ext/image_operations.h",	9 "+skia/ext/image_operations.h",

8 "+sync",	10 "+sync",

9 "+third_party/leveldatabase",	11 "+third_party/leveldatabase",

10 "+third_party/skia/include",	12 "+third_party/skia/include",

11 "+webkit/browser/fileapi",	13 "+webkit/browser/fileapi",

12 ]	14 ]

OLD	NEW

« no previous file with comments | « device/media_transfer_protocol/media_transfer_protocol.gyp ('k') | extensions/browser/api/system_cpu/OWNERS » ('j') | no next file with comments »