chrome/browser/ui/app_list/search/webstore/webstore_result.h - Issue 389613006: Prevent duplicate concurrent installs of the same extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_result.h

Issue 389613006: Prevent duplicate concurrent installs of the same extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/active_install_data.cc ('K') | « chrome/browser/extensions/webstore_standalone_installer.cc ('k') | chrome/browser/ui/app_list/search/webstore/webstore_result.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/webstore/webstore_result.h

diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_result.h b/chrome/browser/ui/app_list/search/webstore/webstore_result.h

index 7be3d87000cf0f3d847dc92de53691ee838a3876..04284b1c8072122a3544674b11f37a13e3370902 100644

--- a/chrome/browser/ui/app_list/search/webstore/webstore_result.h

+++ b/chrome/browser/ui/app_list/search/webstore/webstore_result.h

@@ -43,6 +43,10 @@ class WebstoreResult : public ChromeSearchResult,

virtual ChromeSearchResultType GetType() OVERRIDE;

private:

+ // Set the initial state and start observing both InstallObserver and

+ // ExtensionRegistryObserver.

+ void InitAndStartObserving();

void UpdateActions();

void SetDefaultDetails();

void OnIconLoaded();

@@ -52,9 +56,6 @@ class WebstoreResult : public ChromeSearchResult,

void LaunchCallback(extensions::webstore_install::Result result,

const std::string& error);

- // Start observing both InstallObserver and ExtensionRegistryObserver.

- void StartObserving();

void StopObservingInstall();

void StopObservingRegistry();