Prevent duplicate concurrent installs of the same extension

chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop/message_loop_proxy.h"
 #include "chrome/browser/apps/ephemeral_app_launcher.h"
 #include "chrome/browser/extensions/extension_install_checker.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
+#include "chrome/browser/extensions/install_tracker.h"
 #include "chrome/browser/extensions/test_blacklist.h"
 #include "chrome/browser/extensions/webstore_installer_test.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extension_util.h"
 #include "extensions/browser/management_policy.h"
 
 using extensions::Extension;
 using extensions::ExtensionPrefs;
 using extensions::ExtensionRegistry;
 using extensions::ExtensionSystem;
+using extensions::InstallTracker;
 namespace webstore_install = extensions::webstore_install;
 
 namespace {
 
 const char kWebstoreDomain[] = "cws.com";
 const char kAppDomain[] = "app.com";
 const char kNonAppDomain[] = "nonapp.com";
 const char kTestDataPath[] = "extensions/platform_apps/ephemeral_launcher";
 
 const char kExtensionId[] = "eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeid";
@@ skipping 198 matching lines @@
       EXPECT_FALSE(launched_listener.was_satisfied());
 
     // Check the reference count to ensure the launcher instance will not be
     // leaked.
     EXPECT_TRUE(launcher->HasOneRef());
   }
 
   void RunLaunchTest(const std::string& id,
                      webstore_install::Result expected_result,
                      bool expect_install_initiated) {
+    InstallTracker* tracker = InstallTracker::Get(profile());
+    ASSERT_TRUE(tracker);
+    bool was_install_active = !!tracker->GetActiveInstall(id);
+
     scoped_refptr<EphemeralAppLauncherForTest> launcher(
         new EphemeralAppLauncherForTest(id, profile()));
     StartLauncherAndCheckResult(
         launcher.get(), expected_result, expect_install_initiated);
+
+    // Verify that the install was deregistered from the InstallTracker.
+    EXPECT_EQ(was_install_active, !!tracker->GetActiveInstall(id));
   }
 
   void ValidateAppInstalledEphemerally(const std::string& id) {
     EXPECT_TRUE(GetInstalledExtension(id));
     EXPECT_TRUE(extensions::util::IsEphemeralApp(id, profile()));
   }
 
   const Extension* InstallAndDisableApp(
       const char* test_path,
       Extension::DisableReason disable_reason) {
@@ skipping 253 matching lines @@
 // Verifies that an installed app with unsupported requirements cannot be
 // launched.
 IN_PROC_BROWSER_TEST_F(EphemeralAppLauncherTest,
                        LaunchAppWithUnsupportedRequirements) {
   const Extension* app = InstallAndDisableApp(
       kDefaultAppTestPath, Extension::DISABLE_UNSUPPORTED_REQUIREMENT);
   ASSERT_TRUE(app);
 
   RunLaunchTest(app->id(), webstore_install::REQUIREMENT_VIOLATIONS, false);
 }
+
+// Verifies that a launch will fail if the app is currently being installed.
+IN_PROC_BROWSER_TEST_F(EphemeralAppLauncherTest, InstallInProgress) {
+  extensions::ActiveInstallData install_data(kDefaultAppId);
+  InstallTracker::Get(profile())->AddActiveInstall(install_data);
+
+  RunLaunchTest(kDefaultAppId, webstore_install::INSTALL_IN_PROGRESS, false);
+}
+
+// Verifies that a launch will fail if a duplicate launch is in progress.
+IN_PROC_BROWSER_TEST_F(EphemeralAppLauncherTest, DuplicateLaunchInProgress) {
+  extensions::ActiveInstallData install_data(kDefaultAppId);
+  install_data.is_ephemeral = true;
+  InstallTracker::Get(profile())->AddActiveInstall(install_data);
+
+  RunLaunchTest(kDefaultAppId, webstore_install::LAUNCH_IN_PROGRESS, false);
+}