Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 389573008: Enforce clearing renderers' paint invalidation state (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated TestExpectations for landing. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1561 matching lines...) Expand 10 before | Expand all | Expand 10 after
1572 // If we are set to do a full paint invalidation that means the RenderView w ill be 1572 // If we are set to do a full paint invalidation that means the RenderView w ill be
1573 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child 1573 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child
1574 // renderers as they'll be covered by the RenderView. 1574 // renderers as they'll be covered by the RenderView.
1575 if (view()->doingFullRepaint()) 1575 if (view()->doingFullRepaint())
1576 return; 1576 return;
1577 1577
1578 if ((onlyNeededPositionedMovementLayout() && compositingState() != PaintsInt oOwnBacking) 1578 if ((onlyNeededPositionedMovementLayout() && compositingState() != PaintsInt oOwnBacking)
1579 || (shouldDoFullPaintInvalidationIfSelfPaintingLayer() 1579 || (shouldDoFullPaintInvalidationIfSelfPaintingLayer()
1580 && hasLayer() 1580 && hasLayer()
1581 && layer()->isSelfPaintingLayer())) { 1581 && layer()->isSelfPaintingLayer())) {
1582 setShouldDoFullPaintInvalidation(true); 1582 setShouldDoFullPaintInvalidation(true, MarkOnlyThis);
1583 } 1583 }
1584 1584
1585 if (!RenderObject::invalidatePaintIfNeeded(newPaintInvalidationContainer, ol dPaintInvalidationRect, oldPositionFromPaintInvalidationContainer, paintInvalida tionState)) 1585 if (!RenderObject::invalidatePaintIfNeeded(newPaintInvalidationContainer, ol dPaintInvalidationRect, oldPositionFromPaintInvalidationContainer, paintInvalida tionState))
1586 invalidatePaintForOverflowIfNeeded(); 1586 invalidatePaintForOverflowIfNeeded();
1587 1587
1588 // Issue paint invalidations for any scrollbars if there is a scrollable are a for this renderer. 1588 // Issue paint invalidations for any scrollbars if there is a scrollable are a for this renderer.
1589 if (enclosingLayer()) { 1589 if (enclosingLayer()) {
1590 if (RenderLayerScrollableArea* area = enclosingLayer()->scrollableArea() ) { 1590 if (RenderLayerScrollableArea* area = enclosingLayer()->scrollableArea() ) {
1591 if (area->hasVerticalBarDamage()) 1591 if (area->hasVerticalBarDamage())
1592 invalidatePaintRectangle(area->verticalBarDamage()); 1592 invalidatePaintRectangle(area->verticalBarDamage());
(...skipping 3073 matching lines...) Expand 10 before | Expand all | Expand 10 after
4666 4666
4667 // We need the old border box size only when the box has background or b ox decorations. 4667 // We need the old border box size only when the box has background or b ox decorations.
4668 if (!style()->hasBackground() && !style()->hasBoxDecorations()) 4668 if (!style()->hasBackground() && !style()->hasBoxDecorations())
4669 return; 4669 return;
4670 } 4670 }
4671 4671
4672 ensureRareData().m_previousBorderBoxSize = size(); 4672 ensureRareData().m_previousBorderBoxSize = size();
4673 } 4673 }
4674 4674
4675 } // namespace blink 4675 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698