Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 389573008: Enforce clearing renderers' paint invalidation state (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated TestExpectations for landing. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1015 matching lines...) Expand 10 before | Expand all | Expand 10 after
1026 rootForPaintInvalidation->invalidateTreeIfNeeded(rootPaintInvalidationState) ; 1026 rootForPaintInvalidation->invalidateTreeIfNeeded(rootPaintInvalidationState) ;
1027 1027
1028 // Invalidate the paint of the frameviews scrollbars if needed 1028 // Invalidate the paint of the frameviews scrollbars if needed
1029 if (hasVerticalBarDamage()) 1029 if (hasVerticalBarDamage())
1030 invalidateRect(verticalBarDamage()); 1030 invalidateRect(verticalBarDamage());
1031 if (hasHorizontalBarDamage()) 1031 if (hasHorizontalBarDamage())
1032 invalidateRect(horizontalBarDamage()); 1032 invalidateRect(horizontalBarDamage());
1033 resetScrollbarDamage(); 1033 resetScrollbarDamage();
1034 1034
1035 m_doFullPaintInvalidation = false; 1035 m_doFullPaintInvalidation = false;
1036 #ifndef NDEBUG
1037 renderView()->assertSubtreeClearedPaintInvalidationState();
1038 #endif
1036 } 1039 }
1037 1040
1038 DocumentLifecycle& FrameView::lifecycle() const 1041 DocumentLifecycle& FrameView::lifecycle() const
1039 { 1042 {
1040 return m_frame->document()->lifecycle(); 1043 return m_frame->document()->lifecycle();
1041 } 1044 }
1042 1045
1043 void FrameView::gatherDebugLayoutRects(RenderObject* layoutRoot) 1046 void FrameView::gatherDebugLayoutRects(RenderObject* layoutRoot)
1044 { 1047 {
1045 bool isTracing; 1048 bool isTracing;
(...skipping 2242 matching lines...) Expand 10 before | Expand all | Expand 10 after
3288 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3291 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3289 { 3292 {
3290 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3293 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3291 if (AXObjectCache* cache = axObjectCache()) { 3294 if (AXObjectCache* cache = axObjectCache()) {
3292 cache->remove(scrollbar); 3295 cache->remove(scrollbar);
3293 cache->handleScrollbarUpdate(this); 3296 cache->handleScrollbarUpdate(this);
3294 } 3297 }
3295 } 3298 }
3296 3299
3297 } // namespace blink 3300 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/platform/linux/svg/custom/use-setAttribute-crash-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698