Source/devtools/front_end/timeline/TimelineTracingView.js - Issue 389563002: DevTools: make paint profiler target-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineTracingView.js

Issue 389563002: DevTools: make paint profiler target-aware (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/sdk/PaintProfiler.js ('K') | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TracingTimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineTracingView.js

diff --git a/Source/devtools/front_end/timeline/TimelineTracingView.js b/Source/devtools/front_end/timeline/TimelineTracingView.js

index 0708159b46b04d565fa2e95c5e8cc2bd11635081..8b9c26b813782b5d633a7e743e2bca60f46c17b1 100644

--- a/Source/devtools/front_end/timeline/TimelineTracingView.js

+++ b/Source/devtools/front_end/timeline/TimelineTracingView.js

@@ -128,7 +128,7 @@ WebInspector.TimelineTracingView.prototype = {

* @param {!Node=} node

* @this {WebInspector.TimelineTracingView}

- function appendPreviewAndshowDetails(node)

+ function appendPreviewAndShowDetails(node)

{

if (node)

contentHelper.appendElementRow("Preview", node);

@@ -137,7 +137,7 @@ WebInspector.TimelineTracingView.prototype = {

var recordTypes = WebInspector.TracingTimelineModel.RecordType;

switch (record.name) {

case recordTypes.PictureSnapshot:

- WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(record.args["snapshot"]["skp64"], appendPreviewAndshowDetails.bind(this));

+ WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(this._tracingModel.target(), record.args["snapshot"]["skp64"], appendPreviewAndShowDetails.bind(this));

break;

case recordTypes.LayerTreeHostImplSnapshot:

var link = document.createElement("span");