DevTools: make paint profiler target-aware

Source/devtools/front_end/sdk/PaintProfiler.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
+ * @param {!WebInspector.Target} target
  * @param {string} snapshotId
+ * @extends {WebInspector.SDKObject}
  */
-WebInspector.PaintProfilerSnapshot = function(snapshotId)
+WebInspector.PaintProfilerSnapshot = function(target, snapshotId)

[sergeyv, 2014/07/11 11:29:00]

As we spoke offline, this snapshot can live longer than target which generated
it

 {
+    WebInspector.SDKObject.call(this, target);
     this._id = snapshotId;
 }
 
 /**
+ * @param {!WebInspector.Target} target
  * @param {string} encodedPicture
  * @param {function(?WebInspector.PaintProfilerSnapshot)} callback
  */
-WebInspector.PaintProfilerSnapshot.load = function(encodedPicture, callback)
+WebInspector.PaintProfilerSnapshot.load = function(target, encodedPicture, callback)
 {
-    var wrappedCallback = InspectorBackend.wrapClientCallback(callback, "LayerTreeAgent.loadSnapshot(): ", WebInspector.PaintProfilerSnapshot);
-    LayerTreeAgent.loadSnapshot(encodedPicture, wrappedCallback);
+    var wrappedCallback = InspectorBackend.wrapClientCallback(callback, "LayerTreeAgent.loadSnapshot(): ", WebInspector.PaintProfilerSnapshot.bind(null, target));
+    target.layerTreeAgent().loadSnapshot(encodedPicture, wrappedCallback);
 }
 
 /**
  * @param {!Array.<!WebInspector.RawPaintProfilerLogItem>} log
  * @return {!Array.<!WebInspector.PaintProfilerLogItem>}
  */
 WebInspector.PaintProfilerSnapshot._processAnnotations = function(log)
 {
     var result = [];
     /** @type {!Array.<!Object.<string, string>>} */
@@ skipping 32 matching lines @@
         default:
             result.push(new WebInspector.PaintProfilerLogItem(log[i], i, commentGroupStack.peekLast()));
         }
     }
     return result;
 }
 
 WebInspector.PaintProfilerSnapshot.prototype = {
     dispose: function()
     {
-        LayerTreeAgent.releaseSnapshot(this._id);
+        this.target().layerTreeAgent().releaseSnapshot(this._id);
     },
 
     /**
      * @param {?number} firstStep
      * @param {?number} lastStep
      * @param {?number} scale
      * @param {function(string=)} callback
      */
     requestImage: function(firstStep, lastStep, scale, callback)
     {
         var wrappedCallback = InspectorBackend.wrapClientCallback(callback, "LayerTreeAgent.replaySnapshot(): ");
-        LayerTreeAgent.replaySnapshot(this._id, firstStep || undefined, lastStep || undefined, scale || 1.0, wrappedCallback);
+        this.target().layerTreeAgent().replaySnapshot(this._id, firstStep || undefined, lastStep || undefined, scale || 1.0, wrappedCallback);
     },
 
     /**
      * @param {function(!Array.<!LayerTreeAgent.PaintProfile>=)} callback
      */
     profile: function(callback)
     {
         var wrappedCallback = InspectorBackend.wrapClientCallback(callback, "LayerTreeAgent.profileSnapshot(): ");
-        LayerTreeAgent.profileSnapshot(this._id, 5, 1, wrappedCallback);
+        this.target().layerTreeAgent().profileSnapshot(this._id, 5, 1, wrappedCallback);
     },
 
     /**
      * @param {function(!Array.<!WebInspector.PaintProfilerLogItem>=)} callback
      */
     commandLog: function(callback)
     {
         /**
          * @param {?string} error
          * @param {!Array.<!WebInspector.RawPaintProfilerLogItem>} log
          */
         function callbackWrapper(error, log)
         {
             if (error) {
                 console.error("LayerTreeAgent.snapshotCommandLog(): " + error);
                 callback();
                 return;
             }
             callback(WebInspector.PaintProfilerSnapshot._processAnnotations(log));
         }
-        LayerTreeAgent.snapshotCommandLog(this._id, callbackWrapper);
+
+        this.target().layerTreeAgent().snapshotCommandLog(this._id, callbackWrapper);
     },
 
+    __proto__: WebInspector.SDKObject.prototype
 };
 
 /**
  * @typedef {!{method: string, params: Array.<Object.<string, *>>}}
  */
 WebInspector.RawPaintProfilerLogItem;
 
 /**
  * @constructor
  * @param {!WebInspector.RawPaintProfilerLogItem} rawEntry
  * @param {number} commandIndex
  * @param {!Object.<string, string>=} annotations
  */
 WebInspector.PaintProfilerLogItem = function(rawEntry, commandIndex, annotations)
 {
     this.method = rawEntry.method;
     this.params = rawEntry.params;
     this.annotations = annotations;
     this.commandIndex = commandIndex;
 }