Issue 389553002: Refactoring: Make ~CSSStyleSheetResource empty.

Issue 389553002: Refactoring: Make ~CSSStyleSheetResource empty. (Closed)

Created:
6 years, 5 months ago by tkent

Modified:
6 years, 5 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Refactoring: Make ~CSSStyleSheetResource empty. Introduce Resource::dispose, which is called before |delete this|, and move the content of ~CSSStyleSheetResource to CSSStyleSheetResource::dispose. This makes Resource class Oilpan-friendly. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178036

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add an assertion #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
M	Source/core/fetch/CSSStyleSheetResource.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/fetch/CSSStyleSheetResource.cpp	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/fetch/Resource.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/fetch/Resource.cpp	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/389553002/diff/20001/Source/core/fetch/CSSStyleSheetResource.cpp File Source/core/fetch/CSSStyleSheetResource.cpp (right): https://codereview.chromium.org/389553002/diff/20001/Source/core/fetch/CSSStyleSheetResource.cpp#newcode51 Source/core/fetch/CSSStyleSheetResource.cpp:51: { Shall we call m_parsedStyleSheetCache.clear() in dispose() and ...

6 years, 5 months ago (2014-07-14 07:28:11 UTC) #2

tkent

https://codereview.chromium.org/389553002/diff/20001/Source/core/fetch/CSSStyleSheetResource.cpp File Source/core/fetch/CSSStyleSheetResource.cpp (right): https://codereview.chromium.org/389553002/diff/20001/Source/core/fetch/CSSStyleSheetResource.cpp#newcode51 Source/core/fetch/CSSStyleSheetResource.cpp:51: { On 2014/07/14 07:28:11, haraken wrote: > > Shall ...

6 years, 5 months ago (2014-07-14 08:47:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/389553002/40001

6 years, 5 months ago (2014-07-14 08:48:35 UTC) #5

Message was sent while issue was closed.

Change committed as 178036

Expand Messages | Collapse Messages