Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 389453003: [Mac] Use -close instead of -performClose. (Closed)

Created:
6 years, 5 months ago by jackhou1
Modified:
6 years, 5 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Mac] Use -close instead of -performClose. This ensures the window can close when it has sheets attached, e.g. the "Open File" dialog. BUG=362444 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jackhou1
6 years, 5 months ago (2014-07-11 00:47:20 UTC) #1
tapted
lgtm. there are other side-effects. E.g. with a native frame you might miss out on ...
6 years, 5 months ago (2014-07-11 01:42:24 UTC) #2
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 5 months ago (2014-07-11 02:45:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/389453003/1
6 years, 5 months ago (2014-07-11 02:47:39 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 09:49:44 UTC) #5
Message was sent while issue was closed.
Change committed as 282600

Powered by Google App Engine
This is Rietveld 408576698