Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: tools/perf/benchmarks/spaceport.py

Issue 389443002: Update spaceport to use results.AddValue(...). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/spaceport.py
diff --git a/tools/perf/benchmarks/spaceport.py b/tools/perf/benchmarks/spaceport.py
index 4c378389116b31e7600f82a2f15249594d7a33bf..4d06b631b1da4f62bf2c4b3b839800dee6ae8917 100644
--- a/tools/perf/benchmarks/spaceport.py
+++ b/tools/perf/benchmarks/spaceport.py
@@ -11,6 +11,8 @@ from telemetry import benchmark
from telemetry.core import util
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import list_of_scalar_values
+from telemetry.value import scalar
class _SpaceportMeasurement(page_measurement.PageMeasurement):
@@ -49,10 +51,13 @@ class _SpaceportMeasurement(page_measurement.PageMeasurement):
'JSON.stringify(window.__results)'))
for key in result_dict:
chart, trace = key.split('.', 1)
- results.Add(trace, 'objects (bigger is better)', float(result_dict[key]),
- chart_name=chart, data_type='unimportant')
- results.Add('Score', 'objects (bigger is better)',
- [float(x) for x in result_dict.values()])
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, '%s.%s'% (chart, trace),
+ 'objects (bigger is better)', float(result_dict[key]),
+ important=False))
+ results.AddValue(list_of_scalar_values.ListOfScalarValues(
+ results.current_page, 'Score', 'objects (bigger is better)',
+ [float(x) for x in result_dict.values()]))
# crbug.com/166703: This test frequently times out on Windows.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698