Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: Source/core/inspector/InspectorCSSAgent.cpp

Issue 38943008: Explore the possibility of implementing the CSS Region interface. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Prototype v2 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorCSSAgent.cpp
diff --git a/Source/core/inspector/InspectorCSSAgent.cpp b/Source/core/inspector/InspectorCSSAgent.cpp
index 8ae033bb045d2631f530de7126b151370f720eaa..69f5f16d6f398a3f00942f7b224831d2ef688622 100644
--- a/Source/core/inspector/InspectorCSSAgent.cpp
+++ b/Source/core/inspector/InspectorCSSAgent.cpp
@@ -35,6 +35,7 @@
#include "core/css/CSSImportRule.h"
#include "core/css/CSSMediaRule.h"
#include "core/css/CSSParser.h"
+#include "core/css/CSSRegion.h"
#include "core/css/CSSRule.h"
#include "core/css/CSSRuleList.h"
#include "core/css/CSSStyleRule.h"
@@ -1774,14 +1775,14 @@ PassRefPtr<TypeBuilder::CSS::CSSStyle> InspectorCSSAgent::buildObjectForAttribut
return inspectorStyle->buildObjectForStyle();
}
-PassRefPtr<TypeBuilder::Array<TypeBuilder::CSS::Region> > InspectorCSSAgent::buildArrayForRegions(ErrorString* errorString, PassRefPtr<NodeList> regionList, int documentNodeId)
+PassRefPtr<TypeBuilder::Array<TypeBuilder::CSS::Region> > InspectorCSSAgent::buildArrayForRegions(ErrorString* errorString, Vector<const RenderRegion*> regionList, int documentNodeId)
{
RefPtr<TypeBuilder::Array<TypeBuilder::CSS::Region> > regions = TypeBuilder::Array<TypeBuilder::CSS::Region>::create();
- for (unsigned i = 0; i < regionList->length(); ++i) {
+ for (unsigned i = 0; i < regionList.size(); ++i) {
TypeBuilder::CSS::Region::RegionOverset::Enum regionOverset;
- switch (toElement(regionList->item(i))->renderRegion()->regionOversetState()) {
+ switch (regionList[i]->regionOversetState()) {
case RegionFit:
regionOverset = TypeBuilder::CSS::Region::RegionOverset::Fit;
break;
@@ -1801,7 +1802,7 @@ PassRefPtr<TypeBuilder::Array<TypeBuilder::CSS::Region> > InspectorCSSAgent::bui
RefPtr<TypeBuilder::CSS::Region> region = TypeBuilder::CSS::Region::create()
.setRegionOverset(regionOverset)
// documentNodeId was previously asserted
- .setNodeId(m_domAgent->pushNodeToFrontend(errorString, documentNodeId, regionList->item(i)));
+ .setNodeId(m_domAgent->pushNodeToFrontend(errorString, documentNodeId, regionList[i]->node()));
regions->addItem(region);
}
« Source/core/dom/PseudoElement.idl ('K') | « Source/core/inspector/InspectorCSSAgent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698