Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: pkg/analysis_server/lib/src/computer/computer_hover.dart

Issue 389413002: Use HasToJson when set Reponse/Notification parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/computer/computer_hover.dart
diff --git a/pkg/analysis_server/lib/src/computer/computer_hover.dart b/pkg/analysis_server/lib/src/computer/computer_hover.dart
index 1150480e0cd049ebd4b573f37e4c6d10de6b0901..79215d3390a28dfd282a91e9dc0a6c2ca87c4382 100644
--- a/pkg/analysis_server/lib/src/computer/computer_hover.dart
+++ b/pkg/analysis_server/lib/src/computer/computer_hover.dart
@@ -6,6 +6,7 @@ library computer.hover;
import 'dart:collection';
+import 'package:analysis_server/src/collections.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/element.dart';
@@ -68,7 +69,7 @@ class DartUnitHoverComputer {
/**
* Returns the computed hover, maybe `null`.
*/
- Map<String, Object> compute() {
+ Hover compute() {
AstNode node = new NodeLocator.con1(_offset).searchWithin(_unit);
if (node is Expression) {
Hover hover = new Hover(node.offset, node.length);
@@ -102,7 +103,7 @@ class DartUnitHoverComputer {
hover.staticType = _safeToString(node.staticType);
hover.propagatedType = _safeToString(node.propagatedType);
// done
- return hover.toJson();
+ return hover;
}
// not an expression
return null;
@@ -112,7 +113,7 @@ class DartUnitHoverComputer {
}
-class Hover {
+class Hover implements HasToJson {
final int offset;
final int length;
String containingLibraryName;

Powered by Google App Engine
This is Rietveld 408576698