Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 389393005: Narrow the strike register window in both directions when tracking many (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, avd, Ryan Hamilton
Project:
chromium
Visibility:
Public.

Description

Narrow the strike register window in both directions when tracking many recent nonces. This reduces the amount of time that nonces with future timestamps are tracked, which allows accepting more nonces from clients with clocks that agree with the strike register's clock. Not flag protected. Merge internal change: 69497947 R=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283445

Patch Set 1 #

Patch Set 2 : Added include for limits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -49 lines) Patch
M net/quic/crypto/strike_register.h View 3 chunks +9 lines, -2 lines 0 comments Download
M net/quic/crypto/strike_register.cc View 1 6 chunks +46 lines, -18 lines 0 comments Download
M net/quic/crypto/strike_register_test.cc View 8 chunks +44 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
6 years, 5 months ago (2014-07-14 20:20:32 UTC) #1
wtc
Patch set 1 LGTM.
6 years, 5 months ago (2014-07-14 21:46:10 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 5 months ago (2014-07-15 19:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/389393005/1
6 years, 5 months ago (2014-07-15 19:16:41 UTC) #4
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 5 months ago (2014-07-16 03:30:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/389393005/20001
6 years, 5 months ago (2014-07-16 03:31:03 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:29:55 UTC) #7
Message was sent while issue was closed.
Change committed as 283445

Powered by Google App Engine
This is Rietveld 408576698