Issue 389383002: Revert 277386 "Fix: Adding list of supported codecs for MP4 cont..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389383002: Revert 277386 "Fix: Adding list of supported codecs for MP4 cont..." (Closed)

Created:
6 years, 5 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 5 months ago

Reviewers:
amogh.bihani

CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert 277386 "Fix: Adding list of supported codecs for MP4 cont..." Restoring M36 behavior for M37 BUG=387604 > Fix: Adding list of supported codecs for MP4 containers > > A table is added for MP4 mime types and their corresponding containers > H.264 codecs vary according to the profile version. These are > represented by hexadecimal numbers (RFC6381). These vary across > platforms, hence a definite "probably" cannot be given for canPlayType > query. The best we can say is a "maybe" if the codec is RFC compliant. > > New behaviour of the browser will be > audio/mp4 -> avc1/ avc1./ avc1.4D4001 = "" > audio/mp4 -> mp4a/ mp4a.40/ mp4a.40.2 = "maybe" > audio/mp4 -> mp4a./ mp4a.50/ mp4a.40. = "" > > video/mp4 -> avc1/avc1.4D4001/ = "maybe" > video/mp4 -> avc1./ avc1.NonHexDigits = "" > (similar for mp4a and avc3) > > BUG=53193 > TEST=out/Release/content_browsertests --gtest_filter=MediaCanPlayType* > > Review URL: https://codereview.chromium.org/254983006 TBR=amogh.bihani@samsung.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282963

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+497 lines, -570 lines)			Patch
M	chrome/browser/media/encrypted_media_istypesupported_browsertest.cc	View	16 chunks	+15 lines, -78 lines	0 comments	Download
M	content/browser/media/media_canplaytype_browsertest.cc	View	2 chunks	+450 lines, -332 lines	0 comments	Download
M	content/child/assert_matching_enums.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	net/base/mime_util.h	View	1 chunk	+6 lines, -28 lines	0 comments	Download
M	net/base/mime_util.cc	View	8 chunks	+8 lines, -114 lines	0 comments	Download
M	net/base/mime_util_unittest.cc	View	1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

6 years, 5 months ago (2014-07-14 16:43:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r282963.

Expand Messages | Collapse Messages