Issue 389373004: MIPS: This CL simplifies var / const by ensuring the behavior is consistent in itself, and with reg…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389373004: MIPS: This CL simplifies var / const by ensuring the behavior is consistent in itself, and with reg… (Closed)

Created:
6 years, 5 months ago by balazs.kilvady

Modified:
6 years, 5 months ago

Reviewers:
Paul Lind, danno, kisg, palfia, Toon Verwaest, dusmil, akos.palfi.imgtec

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

MIPS: This CL simplifies var / const by ensuring the behavior is consistent in itself, and with regular JS semantics; between regular var/const and eval-ed var/const. Port r22379 (fb62653) Original commit message: Legacy const is changed so that a declaration declares a configurable, but non-writable, slot, and the initializer reconfigures it (when possible) to non-configurable non-writable. This avoids the need for "the hole" as marker value in JSContextExtensionObjects and GlobalObjects. Undefined is used instead. BUG= R=akos.palfi@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=22385

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -62 lines)			Patch
	M	src/mips/full-codegen-mips.cc	View		5 chunks	+25 lines, -31 lines	0 comments	Download
	M	src/mips64/full-codegen-mips64.cc	View		5 chunks	+29 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

balazs.kilvady

6 years, 5 months ago (2014-07-14 18:22:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22385 (presubmit successful).

Expand Messages | Collapse Messages