DescriptionRevert of DevTools: added injectedScript.evaluateWithDetails, that return exception details if it occured (https://codereview.chromium.org/289423002/)
Reason for revert:
Speculative revert for failing telemetry unit tests. Tests that evaluate scripts that are purposely designed to crash the tab are no longer passing. By intersecting the Mac and windows builder regression ranges I obtained the following range: r178051-r178054. This is the only change in that range that seems related to script execution.
Original issue's description:
> Added V8InjectedScriptHost::evaluateWithDetails. This method returns {result: evaluation result, exceptionDetails: information about the exception, if it occurred}.
> InjectedScriptSource.evaluate and InjectedScriptSource.callFunctionOn uses it. There functions returns additional field with exceptionDetails, if exception occurred.
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178051
TBR=falken@chromium.org
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178079
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 19 (0 generated)
|