Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 389363002: Revert of DevTools: added injectedScript.evaluateWithDetails, that return exception (...) (Closed)

Created:
6 years, 5 months ago by Justin Novosad
Modified:
6 years, 5 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of DevTools: added injectedScript.evaluateWithDetails, that return exception details if it occured (https://codereview.chromium.org/289423002/) Reason for revert: Speculative revert for failing telemetry unit tests. Tests that evaluate scripts that are purposely designed to crash the tab are no longer passing. By intersecting the Mac and windows builder regression ranges I obtained the following range: r178051-r178054. This is the only change in that range that seems related to script execution. Original issue's description: > Added V8InjectedScriptHost::evaluateWithDetails. This method returns {result: evaluation result, exceptionDetails: information about the exception, if it occurred}. > InjectedScriptSource.evaluate and InjectedScriptSource.callFunctionOn uses it. There functions returns additional field with exceptionDetails, if exception occurred. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178051 TBR=falken@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -90 lines) Patch
M Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 3 chunks +1 line, -31 lines 0 comments Download
M Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModuleSource.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 11 chunks +22 lines, -23 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 2 chunks +2 lines, -24 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Justin Novosad
Created Revert of DevTools: added injectedScript.evaluateWithDetails, that return exception details if it occured
6 years, 5 months ago (2014-07-14 16:15:05 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 16:16:07 UTC) #2
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 5 months ago (2014-07-14 16:45:57 UTC) #3
kozyatinskiy1
The CQ bit was unchecked by kozyatinskiy@google.com
6 years, 5 months ago (2014-07-14 16:46:00 UTC) #4
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 5 months ago (2014-07-14 16:46:04 UTC) #5
kozyatinskiy1
The CQ bit was unchecked by kozyatinskiy@google.com
6 years, 5 months ago (2014-07-14 16:46:05 UTC) #6
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 5 months ago (2014-07-14 16:55:15 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 16:56:20 UTC) #8
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 5 months ago (2014-07-14 17:00:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/389363002/1
6 years, 5 months ago (2014-07-14 17:01:12 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 17:01:14 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-14 17:01:15 UTC) #12
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 5 months ago (2014-07-14 17:02:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/389363002/1
6 years, 5 months ago (2014-07-14 17:02:13 UTC) #14
Justin Novosad
The CQ bit was unchecked by junov@chromium.org
6 years, 5 months ago (2014-07-14 17:03:06 UTC) #15
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 5 months ago (2014-07-14 17:03:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/389363002/1
6 years, 5 months ago (2014-07-14 17:04:19 UTC) #17
commit-bot: I haz the power
Change committed as 178079
6 years, 5 months ago (2014-07-14 17:05:00 UTC) #18
Justin Novosad
6 years, 5 months ago (2014-07-14 17:06:55 UTC) #19
Message was sent while issue was closed.
On 2014/07/14 17:05:00, I haz the power (commit-bot) wrote:
> Change committed as 178079

FYI: Reason revert originally failed: issue headline became more that 100 chars
after prepending "Revert of" to it.
After that, had to add TBR and NOTRY to get the commit bot to slam it in.

Powered by Google App Engine
This is Rietveld 408576698