Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 389353003: Add script to bump up version on bleeding edge. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add script to bump up version on bleeding edge. The version.cc file will from now on be controlled on bleeding edge and on trunk. The next version to use will always be max(bleeding_edge_version, trunk_version) + 1. The trunk and bleeding_edge versions are not semantically tied together. The trunk branch can be used to make independent point releases of bleeding_edge revisions. The version on bleeding_edge will be increased if: - the lkgr version is smaller than the version of the latest revision, - the lkgr version is not a version change itself, - the tree is not closed for maintenance. This will allow chromium to refer directly to bleeding_edge revisions of v8. The v8 versions will not be unique, but they will change as often as possible, dependent on the lkgr cycle time and the frequency this script is called. BUG=391261 LOG=n TEST=tools/push-to-trunk/script_test.py TEST=tools/push-to-trunk/bump_up_version.py --dry_run R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22421

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -28 lines) Patch
A tools/push-to-trunk/bump_up_version.py View 1 1 chunk +240 lines, -0 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 3 chunks +30 lines, -1 line 0 comments Download
M tools/push-to-trunk/git_recipes.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 5 chunks +32 lines, -14 lines 0 comments Download
M tools/push-to-trunk/releases.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 6 chunks +101 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/389353003/diff/60001/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/389353003/diff/60001/tools/push-to-trunk/common_includes.py#newcode174 tools/push-to-trunk/common_includes.py:174: def SortingKey(version): Refactoring: Copied from releases.py. https://codereview.chromium.org/389353003/diff/60001/tools/push-to-trunk/common_includes.py#newcode382 tools/push-to-trunk/common_includes.py:382: ...
6 years, 5 months ago (2014-07-15 13:30:34 UTC) #1
Jarin
lgtm
6 years, 5 months ago (2014-07-16 07:00:02 UTC) #2
Michael Achenbach
6 years, 5 months ago (2014-07-16 07:57:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22421 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698