src/hydrogen.cc - Issue 389353002: Remove hole handling since holes cannot occur in JSObjects anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 389353002: Remove hole handling since holes cannot occur in JSObjects anymore. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index a87d623790e0007198cd6bf08ca20a1662606154..018e50fb69585f959141cd6e78b001536abbf37d 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5792,9 +5792,8 @@ HInstruction* HOptimizedGraphBuilder::BuildLoadNamedField(

Handle<JSObject>::cast(object)->Lookup(info->name(), &lookup);

Handle<Object> value(lookup.GetLazyValue(), isolate());

- if (!value->IsTheHole()) {

- return New<HConstant>(value);

- }

+ ASSERT(!value->IsTheHole());

+ return New<HConstant>(value);

}

« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »