Issue 389353002: Remove hole handling since holes cannot occur in JSObjects anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389353002: Remove hole handling since holes cannot occur in JSObjects anymore. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove hole handling since holes cannot occur in JSObjects anymore. The only case in which the hole can still occur, is in a pre-allocated PropertyCell in a GlobalObject. In that case it indicates that the property is absent. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22441

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -50 lines)			Patch
M	src/hydrogen.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/lookup.cc	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	9 chunks	+12 lines, -25 lines	0 comments	Download
M	src/runtime.cc	View	4 chunks	+8 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

6 years, 5 months ago (2014-07-17 09:06:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22441 (presubmit successful).

Expand Messages | Collapse Messages