Roll Skia to f459c85457c

Roll Skia to f459c85457c

https://skia.googlesource.com/skia/+log/bf0b9ced0b..f459c85457c

Updates Chrome GN and GYP for Pavel's SkTextureCompressor opts.

Due to http://crbug.com/393856, landing now
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283230

[mtklein, 2014-07-14 18:40:53]

This needs to land as part of the CL that rolls with 390453002.

Pavel, can you see if this makes sense?

Hal, can you do this, or want me to do the roll?

[krajcevski, 2014-07-14 18:52:57]

https://codereview.chromium.org/389343005/diff/1/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/389343005/diff/1/skia/BUILD.gn#newcode637
skia/BUILD.gn:637: # Non-Neon ARM code.
Does one of these need a:
       "//third_party/skia/src/opts/SkTextureCompression_opts_none.cpp",

..?

https://codereview.chromium.org/389343005/diff/1/skia/skia_library_opts.gyp
File skia/skia_library_opts.gyp (right):

https://codereview.chromium.org/389343005/diff/1/skia/skia_library_opts.gyp#n...
skia/skia_library_opts.gyp:113: [ 'target_arch == "arm" and arm_version < 6', {
Does one of these need either the "neon" or the "none" targets?

[mtklein, 2014-07-14 18:58:16]

https://codereview.chromium.org/389343005/diff/1/skia/skia_library_opts.gyp
File skia/skia_library_opts.gyp (right):

https://codereview.chromium.org/389343005/diff/1/skia/skia_library_opts.gyp#n...
skia/skia_library_opts.gyp:113: [ 'target_arch == "arm" and arm_version < 6', {
On 2014/07/14 18:52:57, krajcevski wrote:
> Does one of these need either the "neon" or the "none" targets?

Not sure.  I had the _arm.cpp unconditionally in both of these (in both files),
but I've switched (both files) to use _arm.cpp for ARM v7+ and _none.cpp for ARM
v6-.  Seems like it's what we do for most optimizations.

[krajcevski, 2014-07-14 20:51:10]

lgtm

On 2014/07/14 18:58:16, mtklein wrote:
> https://codereview.chromium.org/389343005/diff/1/skia/skia_library_opts.gyp
> File skia/skia_library_opts.gyp (right):
> 
>
https://codereview.chromium.org/389343005/diff/1/skia/skia_library_opts.gyp#n...
> skia/skia_library_opts.gyp:113: [ 'target_arch == "arm" and arm_version < 6',
{
> On 2014/07/14 18:52:57, krajcevski wrote:
> > Does one of these need either the "neon" or the "none" targets?
> 
> Not sure.  I had the _arm.cpp unconditionally in both of these (in both
files),
> but I've switched (both files) to use _arm.cpp for ARM v7+ and _none.cpp for
ARM
> v6-.  Seems like it's what we do for most optimizations.

[mtklein, 2014-07-14 20:51:40]

+reed

[reed1, 2014-07-14 20:53:01]

lgtm

[commit-bot: I haz the power, 2014-07-14 20:55:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/389343005/70001

[mtklein, 2014-07-14 21:04:17]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-07-14 21:05:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/389343005/90001

[commit-bot: I haz the power, 2014-07-15 00:06:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-15 00:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 00:27:24]

Try jobs failed on following builders:
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[mtklein, 2014-07-15 00:28:47]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-07-15 00:30:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/389343005/90001

[commit-bot: I haz the power, 2014-07-15 06:07:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-15 06:09:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 06:09:13]

Try jobs failed on following builders:
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[mtklein, 2014-07-15 12:43:48]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-07-15 12:45:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/389343005/90001

[hal.canary, 2014-07-15 12:59:34]

We got a Patch failure.  Can you rebase?

[mtklein, 2014-07-15 13:03:22]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-07-15 13:04:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/389343005/110001

[reed1, 2014-07-15 15:51:18]

The CQ bit was unchecked by reed@google.com

[hal.canary, 2014-07-15 15:51:19]

The CQ bit was unchecked by halcanary@google.com

[reed1, 2014-07-15 15:51:22]

The CQ bit was checked by reed@google.com

[hal.canary, 2014-07-15 15:51:26]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-07-15 15:53:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/389343005/110001

[hal.canary, 2014-07-15 17:17:17]

FYI: held up by http://crbug.com/393856

[reed1, 2014-07-15 19:09:10]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-07-15 19:09:17]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-07-15 19:12:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtklein@chromium.org/389343005/110001

[commit-bot: I haz the power, 2014-07-15 19:16:11]

Change committed as 283230