public/web/WebViewClient.h - Issue 389343002: Custom validation message to take into account text direction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebViewClient.h

Issue 389343002: Custom validation message to take into account text direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix failing test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebViewClient.h

diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h

index 748a9d3dcfa4027d29bf788bf677378f03322b07..aae02024597145555a4a2984031bfd154de754a3 100644

--- a/public/web/WebViewClient.h

+++ b/public/web/WebViewClient.h

@@ -163,6 +163,7 @@ public:

// Show a notification popup for the specified form vaidation messages

// besides the anchor rectangle. An implementation of this function should

// not hide the popup until hideValidationMessage call.

+ virtual void showValidationMessage(const WebRect& anchorInRootView, const WebString& mainText, WebTextDirection mainTextDir, const WebString& supplementalText, WebTextDirection hint) { }

tkent 2014/07/18 13:57:49 |hint| should be renamed to |supplementalTextDir|.

Habib Virji 2014/07/18 15:37:45 Done.

virtual void showValidationMessage(const WebRect& anchorInRootView, const WebString& mainText, const WebString& supplementalText, WebTextDirection hint) { }

// Hide notifation popup for form validation messages.

« Source/web/ValidationMessageClientImpl.cpp ('K') | « Source/web/ValidationMessageClientImpl.cpp ('k') | no next file » | no next file with comments »