Source/core/html/HTMLFormControlElement.cpp - Issue 389343002: Custom validation message to take into account text direction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 389343002: Custom validation message to take into account text direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix failing test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormControlElement.cpp

diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp

index 546f51e2ab5fa829b3f40acf6ca10ebe8e9d4516..fc374d8ffc08414783b162566b54d905173814f2 100644

--- a/Source/core/html/HTMLFormControlElement.cpp

+++ b/Source/core/html/HTMLFormControlElement.cpp

@@ -419,7 +419,7 @@ void HTMLFormControlElement::updateVisibleValidationMessage()

if (message.isEmpty())

client->hideValidationMessage(*this);

else

- client->showValidationMessage(*this, message);

+ client->showValidationMessage(*this, message, customError() ? ValidationMessageClient::CustomMessage: ValidationMessageClient::CannedMessage);

}

void HTMLFormControlElement::hideVisibleValidationMessage()

« no previous file with comments | « no previous file | Source/core/page/ValidationMessageClient.h » ('j') | Source/web/ValidationMessageClientImpl.cpp » ('J')