Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: Source/core/page/ValidationMessageClient.h

Issue 389343002: Custom validation message to take into account text direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved code from web to core Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/ValidationMessageClient.h
diff --git a/Source/core/page/ValidationMessageClient.h b/Source/core/page/ValidationMessageClient.h
index ae2354cd578779bb3d6a26f62cf3ae61fd1db157..fdfa98dbee83290f822b921aa51b74f5f4946293 100644
--- a/Source/core/page/ValidationMessageClient.h
+++ b/Source/core/page/ValidationMessageClient.h
@@ -27,6 +27,7 @@
#define ValidationMessageClient_h
#include "platform/heap/Handle.h"
+#include "platform/text/TextDirection.h"
#include "wtf/Forward.h"
namespace WebCore {
@@ -34,6 +35,7 @@ namespace WebCore {
class Document;
class Element;
+
tkent 2014/07/22 01:29:56 This change is unnecessary.
Habib Virji 2014/07/22 16:10:00 Done.
class ValidationMessageClient : public WillBeGarbageCollectedMixin {
public:
virtual ~ValidationMessageClient() { }
@@ -41,7 +43,7 @@ public:
// Show validation message for the specified anchor element. An
// implementation of this function may hide the message automatically after
// some period.
- virtual void showValidationMessage(const Element& anchor, const String& message) = 0;
+ virtual void showValidationMessage(const Element& anchor, const String& mainMessage, TextDirection, const String& subMessage, TextDirection) = 0;
// Hide validation message for the specified anchor if the message for the
// anchor is already visible.

Powered by Google App Engine
This is Rietveld 408576698