Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: public/web/WebViewClient.h

Issue 389343002: Custom validation message to take into account text direction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed |dir| value read. Updated tests to use setDirection. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // Ask users to choose date/time for the specified parameters. When a user 156 // Ask users to choose date/time for the specified parameters. When a user
157 // chooses a value, an implementation of this function should call 157 // chooses a value, an implementation of this function should call
158 // WebDateTimeChooserCompletion::didChooseValue or didCancelChooser. If the 158 // WebDateTimeChooserCompletion::didChooseValue or didCancelChooser. If the
159 // implementation opened date/time chooser UI successfully, it should return 159 // implementation opened date/time chooser UI successfully, it should return
160 // true. This function is used only if ExternalDateTimeChooser is used. 160 // true. This function is used only if ExternalDateTimeChooser is used.
161 virtual bool openDateTimeChooser(const WebDateTimeChooserParams&, WebDateTim eChooserCompletion*) { return false; } 161 virtual bool openDateTimeChooser(const WebDateTimeChooserParams&, WebDateTim eChooserCompletion*) { return false; }
162 162
163 // Show a notification popup for the specified form vaidation messages 163 // Show a notification popup for the specified form vaidation messages
164 // besides the anchor rectangle. An implementation of this function should 164 // besides the anchor rectangle. An implementation of this function should
165 // not hide the popup until hideValidationMessage call. 165 // not hide the popup until hideValidationMessage call.
166 virtual void showValidationMessage(const WebRect& anchorInRootView, const We bString& mainText, WebTextDirection mainTextDir, const WebString& supplementalTe xt, WebTextDirection supplementalTextDir) { }
166 virtual void showValidationMessage(const WebRect& anchorInRootView, const We bString& mainText, const WebString& supplementalText, WebTextDirection hint) { } 167 virtual void showValidationMessage(const WebRect& anchorInRootView, const We bString& mainText, const WebString& supplementalText, WebTextDirection hint) { }
tkent 2014/08/11 01:45:49 Add a FIXME comment that we'll remove this version
Habib Virji 2014/08/11 20:34:29 Done.
167 168
168 // Hide notifation popup for form validation messages. 169 // Hide notifation popup for form validation messages.
169 virtual void hideValidationMessage() { } 170 virtual void hideValidationMessage() { }
170 171
171 // Move the existing notifation popup to the new anchor position. 172 // Move the existing notifation popup to the new anchor position.
172 virtual void moveValidationMessage(const WebRect& anchorInRootView) { } 173 virtual void moveValidationMessage(const WebRect& anchorInRootView) { }
173 174
174 175
175 // UI ------------------------------------------------------------------ 176 // UI ------------------------------------------------------------------
176 177
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 // Informs the browser that the draggable regions have been updated. 309 // Informs the browser that the draggable regions have been updated.
309 virtual void draggableRegionsChanged() { } 310 virtual void draggableRegionsChanged() { }
310 311
311 protected: 312 protected:
312 ~WebViewClient() { } 313 ~WebViewClient() { }
313 }; 314 };
314 315
315 } // namespace blink 316 } // namespace blink
316 317
317 #endif 318 #endif
OLDNEW
« Source/web/ValidationMessageClientImpl.h ('K') | « Source/web/ValidationMessageClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698