Custom validation message to take into account text direction

Source/web/ValidationMessageClientImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "web/ValidationMessageClientImpl.h"
 
 #include "core/dom/Element.h"
 #include "core/frame/FrameView.h"
+#include "core/html/HTMLInputElement.h"
 #include "core/rendering/RenderObject.h"
 #include "platform/HostWindow.h"
+#include "platform/text/PlatformLocale.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebString.h"
 #include "public/web/WebTextDirection.h"
 #include "public/web/WebViewClient.h"
 #include "web/WebViewImpl.h"
 #include "wtf/CurrentTime.h"
 
 using namespace WebCore;
 
 namespace blink {
@@ skipping 14 matching lines @@
 
 ValidationMessageClientImpl::~ValidationMessageClientImpl()
 {
 }
 
 FrameView* ValidationMessageClientImpl::currentView()
 {
     return m_currentAnchor->document().view();
 }
 
-void ValidationMessageClientImpl::showValidationMessage(const Element& anchor, const String& message)
+static WebTextDirection firstStrongDirection(String message)

[leviw_travelin_and_unemployed, 2014/07/14 19:13:50]

Shouldn't you be iterating over the string until you find the first character
with a strong direction?

We have other code that runs the first part of the UBA to find the
directionality of a string. Look for "determineDirectionality"

[Habib Virji, 2014/07/15 16:33:31]

Agreed, updated code to use determineDirectionality and seems to work fine.

+{
+    const UChar32 character= message.is8Bit() ? message.characters8()[0] : message.characters16()[0];
+    WTF::Unicode::Direction charDirection = WTF::Unicode::direction(character);
+    return charDirection == WTF::Unicode::LeftToRight ? WebTextDirectionLeftToRight: WebTextDirectionRightToLeft;

[leviw_travelin_and_unemployed, 2014/07/14 19:13:50]

This seems wrong. If the *first character* is something like a quotation mark
which isn't strong LTR, we'll use RTL, which is not our normal fallback.

[Habib Virji, 2014/07/15 16:33:31]

Done.

+}
+
+void ValidationMessageClientImpl::showValidationMessage(const Element& anchor, const String& message, bool customError)
 {
     if (message.isEmpty()) {
         hideValidationMessage(anchor);
         return;
     }
     if (!anchor.renderBox())
         return;
     if (m_currentAnchor)
         hideValidationMessage(*m_currentAnchor);
     m_currentAnchor = &anchor;
     IntRect anchorInRootView = currentView()->contentsToRootView(anchor.pixelSnappedBoundingBox());
     m_lastAnchorRectInScreen = currentView()->hostWindow()->rootViewToScreen(anchorInRootView);
     m_lastPageScaleFactor = m_webView.pageScaleFactor();
     m_message = message;
-
-    WebTextDirection dir = m_currentAnchor->renderer()->style()->direction() == RTL ? WebTextDirectionRightToLeft : WebTextDirectionLeftToRight;
-    AtomicString title = m_currentAnchor->fastGetAttribute(HTMLNames::titleAttr);
-    m_webView.client()->showValidationMessage(anchorInRootView, m_message, title, dir);
-
     const double minimumSecondToShowValidationMessage = 5.0;
     const double secondPerCharacter = 0.05;
     const double statusCheckInterval = 0.1;
-    m_finishTime = monotonicallyIncreasingTime() + std::max(minimumSecondToShowValidationMessage, (message.length() + title.length()) * secondPerCharacter);
+
+    if (!customError) {
+        m_webView.client()->showValidationMessage(anchorInRootView, m_message, m_currentAnchor->locale().isRTL() ? WebTextDirectionRightToLeft: WebTextDirectionLeftToRight, String(), WebTextDirectionLeftToRight);
+        m_finishTime = monotonicallyIncreasingTime() + std::max(minimumSecondToShowValidationMessage, message.length() * secondPerCharacter);
+    } else {
+        AtomicString subMsg = m_currentAnchor->fastGetAttribute(HTMLNames::titleAttr);
+        WebTextDirection messageDir = firstStrongDirection(message);
+        WebTextDirection subMsgDir;
+        if (!subMsg.isEmpty()) {
+            // Sub Msg takes direction of the element direction
+            AtomicString dir = m_currentAnchor->fastGetAttribute(HTMLNames::dirAttr);
+            if (dir.isEmpty())
+                subMsgDir = m_currentAnchor->renderer()->style()->direction() == LTR ? WebTextDirectionLeftToRight: WebTextDirectionRightToLeft;
+            else
+                subMsgDir = (equalIgnoringCase(dir, "auto") ? firstStrongDirection(subMsg.string()): (equalIgnoringCase(dir, "ltr") ? WebTextDirectionLeftToRight: WebTextDirectionRightToLeft));
+        }
+        m_webView.client()->showValidationMessage(anchorInRootView, m_message, messageDir, subMsg, subMsgDir);
+        m_finishTime = monotonicallyIncreasingTime() + std::max(minimumSecondToShowValidationMessage, (message.length() + subMsg.length()) * secondPerCharacter);
+    }
+
     // FIXME: We should invoke checkAnchorStatus actively when layout, scroll,
     // or page scale change happen.
     m_timer.startRepeating(statusCheckInterval, FROM_HERE);
 }
 
 void ValidationMessageClientImpl::hideValidationMessage(const Element& anchor)
 {
     if (!m_currentAnchor || !isValidationMessageVisible(anchor))
         return;
     m_timer.stop();
@@ skipping 45 matching lines @@
         hideValidationMessage(*m_currentAnchor);
 }
 
 void ValidationMessageClientImpl::trace(Visitor* visitor)
 {
     visitor->trace(m_currentAnchor);
     ValidationMessageClient::trace(visitor);
 }
 
 }